CI build by github actions #42

chcg · 2023-03-12T09:24:50Z

Please comment what is of interest from your point of view, so I could modify the PR to the relevant once (comment out or remove).
Just used release builds. For debug builds also the ctests are running but for no target they are completely working and therefore not added here.

CI builds of desktop versions (against prebuild QT packages):

windows msvc x64
linux gcc x64 (QT apt package is just 6.2.4 on ubuntu 22.04, installed additionally 6.7.2
macos clang (installation failure for QT 6.7.x)
CI builds of smartphone versions:
linux android (NOK, cmake config issue, not added to workflow)
macos ios (NOK, cmake config issue, not added to workflow)

CI builds of openssl, qt libs + ausweisapp with this libs:

windows msvc x64
linux gcc x64
macos clang
CI builds of smartphone versions:
linux android (just libs as there are config issues with the app)
macos ios (just libs as there are config issues with the app)

misery · 2023-03-22T15:07:57Z

Thanks! Did it work on your pipeline? I see 6 failing checks here. :-)

chcg · 2023-03-23T22:32:53Z

@misery As written above the builds which are mentioned as NOK (Not OK) also fail on my side. I would consider this PR as a starting point if this is of interest and start with adding the working once and further work on the failing ones.

GitMensch · 2023-07-27T07:47:49Z

What do you think about commenting the currently not working ones, then pull this in and have a separate PR for each of the failing ones?

Currently there are none of those CI builds, so the ones that work are already much better than nothing and concentrating on enabling a single one is likely more productive, too.

misery · 2023-09-25T13:30:54Z

I will add any working action. :-)
So strip out the non-working actions into another pull request.

GitMensch · 2023-09-30T12:12:28Z

Thanks for the update. Two failing actions left, which miss some qt6 dependencies and should afterwards pass.

chcg · 2023-10-01T08:08:13Z

@GitMensch
These two failing jobs where already running previously but now the package 'libclang-dev' is version 14 from apt which differs from the libclang package already installed within the docker container (https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md 13.0.1 and 14) found by cmake which is still version 13.

GitMensch · 2023-10-01T08:11:51Z

So sudo apt update and all is fine?

misery

After that... please squash the commits

misery · 2024-03-25T12:31:18Z

.github/workflows/CI_build_libs.yml

+
+    - name: Install packages via apt
+      run: |
+           sudo apt-get update -qq && sudo apt install -y cmake pkg-config libssl-dev libudev-dev libhttp-parser-dev libpcsclite-dev libgl1-mesa-dev libdbus-1-dev libclang-15-dev libclang-13-dev ninja-build


libssl-dev libudev-dev libhttp-parser-dev libpcsclite-dev shouldn't be needed for an Android build. Also libclang-15/13 ... that should be in Android NDK.

For compilation of the QT host tools I think they are needed. Regarding Clang 13/14/15 see below.

misery · 2024-03-25T12:31:41Z

.github/workflows/CI_build_libs.yml

+
+    - name: Install packages via apt
+      run: |
+           sudo apt-get update -qq && sudo apt install -y cmake pkg-config libssl-dev libudev-dev libhttp-parser-dev libpcsclite-dev libgl1-mesa-dev libdbus-1-dev libclang-15-dev libclang-13-dev ninja-build


why libclang15 and 13?

See https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md. Clang 13, 14 and 15 is available and it seems it is not always stable which one is found by the QT build.
Needed to avoid issue similar to:

CMake Warning (dev) at /home/runner/work/AusweisApp/AusweisApp/_build/b/src/qt-build/qtbase/lib/cmake/Qt6Qml/Qt6QmlBuildInternals.cmake:404 (message):
INSTALL_SOURCE_QMLTYPES option is deprecated and should not be used.
Please port your module to use declarative type registration.
Call Stack (most recent call first):
qtwebsockets/src/imports/qmlwebsockets/CMakeLists.txt:4 (qt_internal_add_qml_module)
This warning is for project developers. Use -Wno-dev to suppress it.

-- Configuring submodule 'qtscxml'
-- Configuring submodule 'qtactiveqt'
-- Configuring submodule 'qttools'
CMake Error at /usr/lib/llvm-14/lib/cmake/clang/ClangTargets.cmake:750 (message):
The imported target "clangBasic" references the file

"/usr/lib/llvm-14/lib/libclangBasic.a"

but this file does not exist. Possible reasons include:

The file was deleted, renamed, or moved to another location.

An install or uninstall procedure did not complete successfully.

The installation package was faulty and contained

"/usr/lib/llvm-14/lib/cmake/clang/ClangTargets.cmake"

but not all the files it references.

Call Stack (most recent call first):
/usr/lib/cmake/clang-14/ClangConfig.cmake:19 (include)
qttools/cmake/FindWrapLibClang.cmake:17 (find_package)
qtbase/cmake/QtFindPackageHelpers.cmake:147 (find_package)
qttools/configure.cmake:20 (qt_find_package)
qtbase/cmake/QtFeature.cmake:592 (include)
qttools/src/CMakeLists.txt:18 (qt_feature_evaluate_features)

-- Configuring incomplete, errors occurred!

misery · 2024-03-25T12:32:03Z

.github/workflows/CI_build_combined.yml

+      run: |
+           cmake --build ${{ env.BUILD_DIR_LIBS }} --config ${{ matrix.build_configuration }}
+
+    # - name: generate cmake


remove comment please... let's create a PR after this

@misery Did I get you right that the known failing parts should be active to see the problems or should I remove that parts for the PR and create a new one? I think you mean the second option.

misery · 2024-03-25T12:32:09Z

.github/workflows/CI_build_combined.yml

+      run: |
+           cmake -G "${{ matrix.build_platform }}" -DCMAKE_BUILD_TYPE="${{ matrix.build_configuration }}" -DCMAKE_PREFIX_PATH=./_build_libs/dist -B ${{ env.BUILD_DIR_APP }}
+
+    # due to https://bugreports.qt.io/browse/QTBUG-117765 QT 6.5.3 fails


remove comment please... let's create a PR after this

misery · 2024-03-25T12:32:13Z

.github/workflows/CI_build_combined.yml

+           cmake --build ${{ env.BUILD_DIR_LIBS }} --config ${{ matrix.build_configuration }}
+           cmake --install ${{ env.BUILD_DIR_LIBS }}
+
+    # - name: generate cmake


remove comment please... let's create a PR after this

misery · 2024-03-25T12:32:54Z

.github/workflows/CI_build_combined.yml

+
+    - name: Install packages via apt
+      run: |
+           sudo apt-get update -qq && sudo apt install -y cmake pkg-config libssl-dev libudev-dev libhttp-parser-dev libpcsclite-dev libgl1-mesa-dev libdbus-1-dev libclang-15-dev libclang-13-dev ninja-build


see beneath

misery · 2024-03-25T12:33:07Z

.github/workflows/CI_build.yml

+      run: |
+           ctest --test-dir _build --output-on-failure -C "${{ matrix.build_configuration }}"
+
+  # build_ios:


remove comment, please

misery · 2024-03-25T12:33:21Z

.github/workflows/CI_build.yml

+      run: |
+           ctest --test-dir _build --output-on-failure -C "${{ matrix.build_configuration }}"
+
+  # build_linux_android:


see beneath

misery · 2024-03-25T12:35:06Z

.github/workflows/CI_build.yml

+    - name: Install Qt
+      uses: jurplel/install-qt-action@v3
+      with:
+        version: '6.5.*'
+        modules: 'qtscxml qtwebsockets qtshadertools qtconnectivity'
+        setup-python: 'false'


Yes, if we use a combined build there is no need for a separate lib build job.

Strange error. Did you just Multi-Config Ninja Genereator somewhere? Maybe you could remove --config Release as it is needed for Multi-Config only.

hypery2k · 2024-04-09T16:24:42Z

first thanks for the docker container. Very usefull for end2end testing. Are you aware of issues with docker tag latest aka 2.1.0?

We noticed that our CI builds are failing with SAML checks with 2.1.0, but with 2.0.0 they work

misery · 2024-04-10T08:30:48Z

first thanks for the docker container. Very usefull for end2end testing. Are you aware of issues with docker tag latest aka 2.1.0?

We noticed that our CI builds are failing with SAML checks with 2.1.0, but with 2.0.0 they work

Do you mean the official Container SDK? If you have an issue please report this to support@ausweisapp.de.

hypery2k · 2024-04-10T09:00:44Z

no, we using the docker image for verifying our login process for the identity card.

misery · 2024-04-10T09:02:20Z

no, we using the docker image for verifying our login process for the identity card.

If you mean this: https://hub.docker.com/r/governikus/ausweisapp2 ... please report to the mail address above.

hypery2k · 2024-04-17T06:15:42Z

FYI: With latest 2.1.1 docker image it's working again

GitMensch · 2024-09-12T05:25:17Z

As everything is building again now... @chcg can you please squash the commits with a reasonable commit message for the addition of the CI builds? I think this is the only outstanding request from @misery, so we may be able to get this PR finally merged and be able to then go on with possible adjustments like more environments, maybe ccache backed up GH caching, debug builds to run ctest, at least for some environments... anything else?

- requested changes to use cmake --install - added combined action with lib and app build - Fixed codeql.yml apt failure and update to v3 CI builds of desktop versions (against prebuild QT packages): - windows msvc x64 (NOK, qt build issue, commented out) - linux gcc x64 - macos clang CI builds of smartphone versions: - linux android (NOK, cmake config issue, commented out) - macos ios (NOK, cmake config issue, commented out) CI builds of openssl, qt libs: - windows msvc x64 - linux gcc x64 - macos clang CI builds of smartphone versions: - linux android - macos ios

chcg · 2024-09-16T12:07:52Z

@GitMensch Another squash done.

misery · 2024-10-10T09:30:26Z

Thanks a lot for this and sorry for that massive delay.

GitMensch · 2024-10-10T09:54:03Z

Thanks for the final merge and @chcg: quite impressive that you came back to this again and again.
The only thing that I'm now wondering - shouldn't the result be made available as artifacts?

misery · 2024-10-10T13:41:38Z

@GitMensch Sorry, but we won't accept publishing of those artifacts from our repository. It would be too confusing for most people about "official releases".

GitMensch · 2024-10-10T13:46:49Z

Even if you only find the artifacts via the actions tab / CI runs? How does that confuse people [even an "extended" variant that pushes the release to a "continous pre-release only available when manually opening it in GitHub" seems to be not that confusing...]?

Do you plan to include the additional binaries built in the upcoming releases or would you still consider them "best to either be compiled locally or created with a manual fork + action run"?

misery · 2024-10-10T14:58:45Z

I don't see additional binaries here. What do you mean?

If you want an artifact build from github action you can fork the repository.
But we won't publish any artifact that is not build and signed by our verified machines. We cannot give any guarantee for an artifact that is not build by us.

GitMensch · 2024-10-10T15:36:53Z

I don't see additional binaries here. What do you mean?

If I didn't miss something this CI produces the following builds that are not in the release page yet:

GNU/Linux x86_64
IOS

plus Windows without msi (possible package as .zip)

... and yes, I do understand the "no guarantees" part (but then, continuous build artifacts are per definition for testing purposes, not for general use)

chcg force-pushed the appveyor_qt_6 branch 5 times, most recently from 5a774c3 to 4289bfd Compare April 30, 2023 20:17

chcg force-pushed the appveyor_qt_6 branch 5 times, most recently from 22e729e to d964e74 Compare May 13, 2023 20:01

chcg force-pushed the appveyor_qt_6 branch 4 times, most recently from 91762f3 to d226849 Compare June 9, 2023 07:37

chcg force-pushed the appveyor_qt_6 branch from d226849 to 9f5131b Compare July 27, 2023 16:38

chcg force-pushed the appveyor_qt_6 branch from 9f5131b to 5a5fbc8 Compare August 7, 2023 04:42

chcg changed the title ~~Fixed codeql.yml apt failure~~ CI build by github actions Aug 7, 2023

chcg force-pushed the appveyor_qt_6 branch from 5a5fbc8 to 7b9ed85 Compare September 28, 2023 20:37

chcg force-pushed the appveyor_qt_6 branch 3 times, most recently from aa50f64 to 2271e1b Compare October 1, 2023 07:58

chcg force-pushed the appveyor_qt_6 branch 2 times, most recently from 253891e to b4d9a4c Compare November 4, 2023 12:21

chcg force-pushed the appveyor_qt_6 branch from 5564188 to e6868df Compare March 2, 2024 19:12

misery reviewed Mar 25, 2024

View reviewed changes

chcg force-pushed the appveyor_qt_6 branch 4 times, most recently from 2a9ff8f to 3730290 Compare March 28, 2024 07:02

chcg force-pushed the appveyor_qt_6 branch from 3730290 to b5cda59 Compare April 17, 2024 17:06

chcg force-pushed the appveyor_qt_6 branch 3 times, most recently from 5a36ebc to e15cf57 Compare July 5, 2024 21:01

chcg force-pushed the appveyor_qt_6 branch from e15cf57 to 90e93cd Compare July 14, 2024 21:25

chcg force-pushed the appveyor_qt_6 branch 2 times, most recently from 2d1e225 to 6f7b2e1 Compare September 11, 2024 20:52

chcg force-pushed the appveyor_qt_6 branch from 6f7b2e1 to 383f693 Compare September 16, 2024 12:02

misery merged commit c018ec5 into Governikus:community Oct 10, 2024
11 checks passed

chcg deleted the appveyor_qt_6 branch October 10, 2024 19:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI build by github actions #42

CI build by github actions #42

chcg commented Mar 12, 2023 •

edited

Loading

misery commented Mar 22, 2023

chcg commented Mar 23, 2023

GitMensch commented Jul 27, 2023

misery commented Sep 25, 2023 •

edited

Loading

GitMensch commented Sep 30, 2023

chcg commented Oct 1, 2023

GitMensch commented Oct 1, 2023 via email

misery left a comment

misery Mar 25, 2024

chcg Mar 28, 2024

misery Mar 25, 2024

chcg Mar 27, 2024 •

edited

Loading

misery Mar 25, 2024

chcg Mar 27, 2024 •

edited

Loading

misery Mar 25, 2024

misery Mar 25, 2024

misery Mar 25, 2024

misery Mar 25, 2024

misery Mar 25, 2024

misery Mar 25, 2024

hypery2k commented Apr 9, 2024

misery commented Apr 10, 2024

hypery2k commented Apr 10, 2024

misery commented Apr 10, 2024

hypery2k commented Apr 17, 2024

GitMensch commented Sep 12, 2024

chcg commented Sep 16, 2024

misery commented Oct 10, 2024

GitMensch commented Oct 10, 2024

misery commented Oct 10, 2024

GitMensch commented Oct 10, 2024

misery commented Oct 10, 2024

GitMensch commented Oct 10, 2024

CI build by github actions #42

CI build by github actions #42

Conversation

chcg commented Mar 12, 2023 • edited Loading

misery commented Mar 22, 2023

chcg commented Mar 23, 2023

GitMensch commented Jul 27, 2023

misery commented Sep 25, 2023 • edited Loading

GitMensch commented Sep 30, 2023

chcg commented Oct 1, 2023

GitMensch commented Oct 1, 2023 via email

misery left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chcg Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chcg Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hypery2k commented Apr 9, 2024

misery commented Apr 10, 2024

hypery2k commented Apr 10, 2024

misery commented Apr 10, 2024

hypery2k commented Apr 17, 2024

GitMensch commented Sep 12, 2024

chcg commented Sep 16, 2024

misery commented Oct 10, 2024

GitMensch commented Oct 10, 2024

misery commented Oct 10, 2024

GitMensch commented Oct 10, 2024

misery commented Oct 10, 2024

GitMensch commented Oct 10, 2024

chcg commented Mar 12, 2023 •

edited

Loading

misery commented Sep 25, 2023 •

edited

Loading

chcg Mar 27, 2024 •

edited

Loading

chcg Mar 27, 2024 •

edited

Loading